ConstantReservoirDiffusion Interface #269
Open
+17,906
−509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an invalid field in a Marcus type reaction in ORR.rms
`cat` is a default Julia function for concatenating arrays. As a precaution these are renamed to `catalyst` to avoid conflicts
…that are only available locally
this causes an error when the conda backend is set to Null (i.e. julia is disallowed from installing conda packages), see: ReactionMechanismGenerator/RMG-Py#2749 (comment)
ssun30
force-pushed
the
constant_reservoir_diffusion
branch
2 times, most recently
from
681788c to
4ffdd40
Compare
Attempting to Fix the `juliacall` Overhaul on RMG
this interface creates diffusive fluxes between a given domain and a constant concentration reservoir Some bugfixes by Su: Fixed undefined variable S Added missing "export" for ConstantReservoirDiffusion Co-authored-by: Matt Johnson <mjohnson541@gmail.com> Co-authored-by: Su Sun <sun.su@northeastern.edu>
fixup: fix assignment to dot addition .+=
rwest
force-pushed
the
constant_reservoir_diffusion
branch
from
4ffdd40 to
846c683
Compare
|
Most of this is in #270 and this should be rebased and merged after that is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a constant reservoir diffusion interface for liquid phase domains that simulates diffusive fluxes between the domain and a constant concentration reservoir.